Skip to content

Commit

Permalink
Avoid calling BasicToolbar.populate() multiple times
Browse files Browse the repository at this point in the history
  • Loading branch information
yakky committed Jan 29, 2015
1 parent 851652b commit 18adab2
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions cms/cms_toolbar.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,17 +98,19 @@ class BasicToolbar(CMSToolbar):
"""
Basic Toolbar for site and languages menu
"""
page = None

def init_from_request(self):
self.page = get_page_draft(self.request.current_page)

def populate(self):
self.init_from_request()
if not self.page:
self.init_from_request()

self.add_admin_menu()
self.add_language_menu()
user_settings = self.request.toolbar.get_user_settings()
self.clipboard = user_settings.clipboard
self.add_admin_menu()
self.add_language_menu()
user_settings = self.request.toolbar.get_user_settings()
self.clipboard = user_settings.clipboard

def add_admin_menu(self):
admin_menu = self.toolbar.get_or_create_menu(ADMIN_MENU_IDENTIFIER, self.current_site.name)
Expand Down

0 comments on commit 18adab2

Please sign in to comment.