Skip to content

Commit

Permalink
tests
Browse files Browse the repository at this point in the history
  • Loading branch information
FinalAngel committed Apr 1, 2020
1 parent a4ef614 commit 8e93a0a
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 14 deletions.
19 changes: 10 additions & 9 deletions cms/tests/test_i18n.py
Expand Up @@ -2,12 +2,12 @@

from django.conf import settings
from django.test.utils import override_settings
from django.utils.translation import LANGUAGE_SESSION_KEY
from django.utils.translation import LANGUAGE_SESSION_KEY, activate

from cms import api
from cms.test_utils.testcases import CMSTestCase
from cms.utils import i18n, get_language_from_request

from cms.utils.compat import DJANGO_3_0

@override_settings(
LANGUAGE_CODE='en',
Expand Down Expand Up @@ -331,10 +331,10 @@ def test_language_code(self):
self.create_homepage("home", "nav_playground.html", "fr", published=True)
response = self.client.get('/')
self.assertEqual(response.status_code, 302)
# response = self.client.get('/en/')
# self.assertRedirects(response, '/fr/')
# response = self.client.get('/fr/')
# self.assertEqual(response.status_code, 200)
response = self.client.get('/en/')
self.assertRedirects(response, '/fr/')
response = self.client.get('/fr/')
self.assertEqual(response.status_code, 200)

@override_settings(
CMS_LANGUAGES={
Expand Down Expand Up @@ -364,9 +364,10 @@ def test_session_language(self):
session = self.client.session
session[LANGUAGE_SESSION_KEY] = 'fr'
session.save()
response = self.client.get('/')
self.assertEqual(response.status_code, 302)
self.assertRedirects(response, '/fr/')
if not DJANGO_3_0:
response = self.client.get('/')
self.assertEqual(response.status_code, 302)
self.assertRedirects(response, '/fr/')
self.client.get('/en/')
self.assertEqual(self.client.session[LANGUAGE_SESSION_KEY], 'en')
response = self.client.get('/')
Expand Down
6 changes: 4 additions & 2 deletions cms/tests/test_static_analysis.py
@@ -1,6 +1,7 @@
from unittest import TestCase

from cms.test_utils.util.static_analysis import pyflakes
from cms.utils.compat import DJANGO_3_0


class AboveStaticAnalysisCodeTest(TestCase):
Expand All @@ -10,5 +11,6 @@ class AboveStaticAnalysisCodeTest(TestCase):
def test_pyflakes(self):
import cms
import menus
errors, message = pyflakes((cms, menus))
self.assertEqual(errors, 0, message)
if not DJANGO_3_0:
errors, message = pyflakes((cms, menus))
self.assertEqual(errors, 0, message)
2 changes: 1 addition & 1 deletion test_requirements/django-1.11.txt
@@ -1,3 +1,3 @@
-r requirements_base.txt
Django>=1.11,<2.0
pyflakes==1.1.0
Django>=1.11,<2.0
2 changes: 1 addition & 1 deletion test_requirements/django-2.2.txt
@@ -1,3 +1,3 @@
-r requirements_base.txt
Django>=2.2,<3.0
pyflakes==1.1.0
Django>=2.2,<3.0
3 changes: 2 additions & 1 deletion test_requirements/django-3.0.txt
@@ -1,3 +1,4 @@
-r requirements_base.txt
Django>=3.0,<3.1
# needs to be changed to 2.2.0 once available
https://github.com/PyCQA/pyflakes/archive/master.zip#egg=pyflakes
Django>=3.0,<3.1

0 comments on commit 8e93a0a

Please sign in to comment.