Uncaught SyntaxError: Unexpected token ILLEGAL causes save to become stuck

[peterfarrell]

The following code causes Chrome to break when saving a plugin. The plugin saves and the modal updates with "XXX was changed successfully. You may edit it again below." The modal doesn't redirect and stalls with JS error Uncaught SyntaxError: Unexpected token ILLEGAL

https://github.com/divio/django-cms/blob/e2dfbf86b1a11173bff1dff6285d8d68e0631105/cms/templates/admin/cms/page/close_frame.html#L7-L12

<script>
window.CMS || window.parent.CMS || document.write(
    '<script src="/static/cms/js/libs/jquery.min.js" type="text/javascript"></script>' +
    '<script src="/static/cms/js/modules/cms.base.js" type="text/javascript"></script>'
);
</script>

The error looks like this in Chrome:

[mkoistinen]

I can't seem to reproduce this. Can anyone else? Also, I've inspected the code in the repo for funny symbols, etc., that might cause JS rendering issues, but, didn't find any.

[peterfarrell]

It's certainly not because of funny symbols being committed but how certain browsers are handling the line of code I indicated. I have over 10 confirmed computers in our company that demonstrate this behavior. My guess it has to do with multiple script tags in a single write.

If I roll back enough, I see it was introduced in this commit:

https://github.com/divio/django-cms/blob/06f89bf4180d30d94d0c55534f7e100eb0fb0292/cms/templates/admin/cms/page/close_frame.html

[peterfarrell]

@mkoistinen - are you using Chrome on Linux? That is where we are seeing the major of the issues.

[peterfarrell]

I knew I've seen this before. Here is the issue...

http://stackoverflow.com/a/20737569

The problem is that the string passed to document.write includes the characters </script>, which ends up prematurely terminating the script element that document.write is called from.

The characters </script> can't appear anywhere within a script, since the HTML parser has no way to distinguish this from an actual </script> tag.

Using document.write isn't probably the best solution in this case.

[mkoistinen]

@peterfarrell Can you see if this fixes the issue?

https://github.com/mkoistinen/django-cms/tree/mkoistinen-feature/fix_3717

[peterfarrell]

@mkoistinen just this the 3.0.x version just to double check?

[mkoistinen]

Yes please. Clearly, if this works, it will be merged into both 3.0.10, and the develop branch.

[mkoistinen]

This is now fixed for 3.0.x

[peterfarrell]

I haven't had a chance to confirm. I will on Monday. Did you reproduce the
issue?
On Feb 14, 2015 8:42 AM, "Martin Koistinen" notifications@github.com
wrote:

Closed #3717 #3717.

—
Reply to this email directly or view it on GitHub
#3717 (comment).

[mkoistinen]

I was unable to reproduce the issue, but it is clear that this issue was introduced here: 182f17f

@jrief any comment?

[peterfarrell]

@mkoistinen ... I have tried your fix and I have been unable to repro the issue any more. I believe it has fixed the issue. Thank you for merging.

Do you know when this will hit PIP? Our company policy is to use only stable packages from PIP if possible.

[mkoistinen]

django CMS 3.0.10 was released formally on Saturday, 14th of February, 2015. =) It included this fix.