Scape simple quotes to avoid javascript warnings if not properly used

[mariocesar]

No description provided.

[ojii]

Are those quotes really required?

[mariocesar]

The issue is that the english translation doesn't have inside quotes and spanish translation does.

<script type="text/javascript">
    //<![CDATA[
    // dynamic variables for the toolbar js file
    var placeholder_data = {};
    var page_is_defined = true;
    var translations = {
        move_slot: 'Mover a %(name)s',
        question: '¿Seguro que desea eliminar este 'plugin'?'
    };
    # ...
</script>

This obviously will not work. '¿Seguro que desea eliminar este 'plugin'?' needs to scape the inside simple quotes in order for the javascript code be valid.

I am not sure what would be the best if changing the translations, or escaping the lines on the templates.

[ojii]

I think we need a better way to solve this. It happened all the time (always spanish for some reason...). We probably need something like {% js_escaped_trans "mystring" %} or whatever...

[mariocesar]

I agree about filtering instead of changing the translation.

I made some commits on my fork:
→ 244114c4d757f13b0488dcb901da1f4baa0d78a3
→ 897eb0ef557db9efa313d632c4263306dacde250
→ d7b24a3bfb8e94bcd58d7e30be68f1b4f72b613d

This will escape the javascript strings to make it safe, added a new filter js_string on the js.py templatetag

[mariocesar]

I am closing this pull request, and open this other #1046 with the js_string filter.

Thanks for the time, I fix the problem for my sites, that is great :-)

[ojii]

discussion at https://groups.google.com/forum/#!topic/django-cms-developers/pox52tzwgP0