Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1767: cms.utils.i18n.get_fallback_languages may fail if LANGUAGES has more languages than CMS_LANGUAGES #1768

Merged
merged 2 commits into from Mar 12, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
35 changes: 35 additions & 0 deletions cms/tests/i18n.py
@@ -1,5 +1,7 @@
from cms.test_utils.testcases import SettingsOverrideTestCase
from cms.utils import i18n
from cms.utils.i18n import get_fallback_languages


class TestLanguages(SettingsOverrideTestCase):

Expand Down Expand Up @@ -269,3 +271,36 @@ def test_get_languages_undefined_site(self):
for lang in result:
self.assertEqual(lang['public'], True)
self.assertEqual(lang['hide_untranslated'], False)


class TestLanguagesNotInCMSLanguages(SettingsOverrideTestCase):
settings_overrides = {
'LANGUAGE_CODE': 'en',
'LANGUAGES': [
('en', 'English'),
('de', 'German'),
('fr', 'French')
],
'CMS_LANGUAGES': {
1: [
{
'code': 'de',
'name': 'German',
'public': True,
},
{
'code': 'fr',
'name': 'French',
'public': True
}
],
'default': {
'fallbacks': ['de', 'fr'],
}
},
'SITE_ID': 1,
}

def test_get_fallback_languages(self):
languages = get_fallback_languages('en', 1)
self.assertEqual(languages, ['de', 'fr'])
5 changes: 4 additions & 1 deletion cms/utils/i18n.py
Expand Up @@ -162,7 +162,10 @@ def get_fallback_languages(language, site_id=None):
"""
returns a list of fallback languages for the given language
"""
language = get_language_object(language, site_id)
try:
language = get_language_object(language, site_id)
except LanguageError:
language = get_languages(site_id)[0]
return language.get('fallbacks', [])


Expand Down