stop using mptt.register and deprecated/unused AlreadyRegistered exception in sample model #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption in sample model
digi604
added a commit
that referenced
this pull request
Aug 8, 2013
stop using mptt.register and deprecated/unused AlreadyRegistered exception in sample model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm about to release mptt 0.6. I almost removed mptt.AlreadyRegistered, but luckily I ack'd the django-cms codebase and it's still in the sample models file.
AlreadyRegistered hasn't been thrown since mptt 0.3, so not much point catching it. I took the liberty of switching to MPTTModel instead of mptt.register() too, since it's a bit prettier.