Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better syntax for trans in base.html #3030

Merged
merged 1 commit into from Apr 9, 2014

Conversation

yakky
Copy link
Member

@yakky yakky commented Apr 9, 2014

Uses filter instead of context vars to handle filters on translated strings

@digi604
Copy link
Contributor

digi604 commented Apr 9, 2014

seams not to be supported by django 1.4 :(

@yakky
Copy link
Member Author

yakky commented Apr 9, 2014

Can't understand failures. Syntax is valid in django 1.4 (escape is not supported in filter, but escapejs is). Checking the failures

@digi604
Copy link
Contributor

digi604 commented Apr 9, 2014

mmh it seams travis has some troubles this morning

@FinalAngel
Copy link
Member

I'm neither a fan of {% filter escapejs %} it causes weird syntax displays within the IDE...

@yakky
Copy link
Member Author

yakky commented Apr 9, 2014

@digi604 : it's your call, then :)

digi604 added a commit that referenced this pull request Apr 9, 2014
Better syntax for trans in base.html
@digi604 digi604 merged commit 55572f9 into django-cms:develop Apr 9, 2014
@yakky yakky deleted the feature/better_trans branch November 8, 2014 22:20
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.444% when pulling 90a5f13 on yakky:feature/better_trans into f8e4685 on divio:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.444% when pulling 90a5f13 on yakky:feature/better_trans into f8e4685 on divio:develop.

@coveralls
Copy link

coveralls commented Feb 14, 2018

Coverage Status

Coverage remained the same at 94.444% when pulling 90a5f13 on yakky:feature/better_trans into f8e4685 on divio:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants