Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Shift+click for advanced page options #3226

Merged
merged 1 commit into from
Jun 6, 2014

Conversation

yakky
Copy link
Member

@yakky yakky commented Jun 3, 2014

ALT+Click is used on linux to drag windows around.

@yakky
Copy link
Member Author

yakky commented Jun 3, 2014

@FinalAngel could you check this? I'm not aware of any other conflicting assignment for this combination

@coveralls
Copy link

coveralls commented Jun 3, 2014

Coverage Status

Coverage decreased (-0.08%) to 88.061% when pulling 31db707 on yakky:feature/alt_shift into a8df328 on divio:develop.

@yakky
Copy link
Member Author

yakky commented Jun 3, 2014

@mkoistinen any opinion?

@mkoistinen
Copy link
Contributor

I originally considered this, but using shift means that's the icon changes state as the user types elsewhere on the page in mixed case, so what we have now felt cleaner.

Otherwise, no opinion.

Sent from Mailbox

On Tue, Jun 3, 2014 at 5:43 PM, Iacopo Spalletti notifications@github.com
wrote:

@mkoistinen any opinion?

Reply to this email directly or view it on GitHub:
#3226 (comment)

digi604 added a commit that referenced this pull request Jun 6, 2014
Switch to Shift+click for advanced page options
@digi604 digi604 merged commit 6961120 into django-cms:develop Jun 6, 2014
@yakky yakky deleted the feature/alt_shift branch November 8, 2014 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants