Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed metaclass support in Python 3 #3272

Merged
merged 2 commits into from
Jul 7, 2014
Merged

Fixed metaclass support in Python 3 #3272

merged 2 commits into from
Jul 7, 2014

Conversation

mmarzantowicz
Copy link

Use django.utils.six to allow metaclass support in Python 2 and Python 3.

@coveralls
Copy link

coveralls commented Jun 26, 2014

Coverage Status

Coverage decreased (-0.08%) to 88.0% when pulling 6e8c98a on mmarzantowicz:feature/toolbar_py3_compat into f58060c on divio:develop.

@mmarzantowicz
Copy link
Author

One thing needs to be clarified. I've chosen "older" with_metaclass implementation from django.utils.six (<=1.7) over that available in django CMS because it's sufficient. Ideally cms.utils.compat.metaclasses module would be replaced with six module already available in django. However, this must wait till django 1.7 is minimum supported version by django CMS. This is because version used currently by django CMS is available in django since about version 1.7.

digi604 added a commit that referenced this pull request Jul 7, 2014
@digi604 digi604 merged commit a85ed52 into django-cms:develop Jul 7, 2014
@mmarzantowicz mmarzantowicz deleted the feature/toolbar_py3_compat branch July 7, 2014 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants