Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Django 1.4 / 1.5 #3525

Merged
merged 3 commits into from Nov 5, 2014
Merged

Conversation

yakky
Copy link
Member

@yakky yakky commented Oct 18, 2014

No description provided.

@yakky yakky added this to the 3.1 milestone Oct 18, 2014
@yakky
Copy link
Member Author

yakky commented Oct 18, 2014

Ping @mkoistinen @digi604 @ojii

@mkoistinen
Copy link
Contributor

I'm all for this.

* `South`_ 1.0
* `django-classy-tags`_ 0.5 or higher
* `django-mptt`_ 0.6 (strict due to API compatibility issues)
* `django-treebeard`_ 2.0 (strict due to API compatibility issues)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in this PR? Seems unrelated to dropping Django version support.

@timgraham
Copy link
Contributor

Do you want to make removing all the django.VERSION >= (1, 5) and related stuff part of this PR?

@@ -228,7 +228,7 @@ or has to have edit permission on that specific object of that model.
Model permissions are usually added through default django auth application
and its admin interface. On the other hand, object permission can be handled by
writing custom Auth Backend as described in
`django docs <https://docs.djangoproject.com/en/1.5/topics/auth/customizing/#handling-object-permissions>`_
`django docs <https://docs.djangoproject.com/en/1.7/topics/auth/customizing/#handling-object-permissions>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also replace "1.7" with "stable", although there is the chance the link could break if we restructure the Django docs.

@yakky
Copy link
Member Author

yakky commented Oct 24, 2014

@timgraham this is a documentation / test changes only.
The actual code removal will take a few iterations

@yakky
Copy link
Member Author

yakky commented Oct 24, 2014

Complied with @ojii comment: different PR will take care of removing last mptt reference from docs

@yakky yakky mentioned this pull request Nov 2, 2014
ojii added a commit that referenced this pull request Nov 5, 2014
Drop support for Django 1.4 / 1.5
@ojii ojii merged commit ac3bc6a into django-cms:develop Nov 5, 2014
@yakky yakky deleted the feature/drop_1.5 branch November 8, 2014 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants