Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add render_model_add_block tag #3875

Merged

Conversation

mkoistinen
Copy link
Contributor

OK, this works nicely to satisfy #3873, but would be even better if ClassyTags would let me declare the nodelist block "argument" as, optional. Anyone know if this is possible?

@mkoistinen
Copy link
Contributor Author

@ojii, is it possible to have a single, but optional block/nodelist defined in an InclusionTag?

@mkoistinen mkoistinen added this to the 3.1 milestone Feb 16, 2015
@mkoistinen
Copy link
Contributor Author

Thats odd. The GitHub integration with Travis says this build failed, but if you click through, it shows all passing tests...

@yakky
Copy link
Member

yakky commented Feb 16, 2015

Travis, go home, you're drunk! :)

@yakky
Copy link
Member

yakky commented Feb 16, 2015

@mkoistinen can you revert the doc change regarding render_model_add? I have a fix for that
Or just leave it and I'll rebase my PR on top of this after the merge

@ojii
Copy link
Contributor

ojii commented Feb 16, 2015

@ojii, is it possible to have a single, but optional block/nodelist defined in an InclusionTag?

No, not without a heavy dose of dark magic. "endblock detection" happens at parse time, not at render time. Argument processing (including the one that would signal if it should scan for an endblock or not) happens at render time.

@mkoistinen
Copy link
Contributor Author

@yakky - done
@ojii, ok, thanks, this implementation will stand then.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 90.94% when pulling b7ab3a1 on mkoistinen:mkoistinen-feature/render_model_add_block into 4a75fae on divio:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 90.94% when pulling b7ab3a1 on mkoistinen:mkoistinen-feature/render_model_add_block into 4a75fae on divio:develop.

@coveralls
Copy link

coveralls commented Feb 16, 2015

Coverage Status

Coverage decreased (-0.07%) to 90.834% when pulling b7ab3a1 on mkoistinen:mkoistinen-feature/render_model_add_block into 4a75fae on divio:develop.

yakky added a commit that referenced this pull request Feb 20, 2015
…del_add_block

Add render_model_add_block tag
@yakky yakky merged commit a5dae7d into django-cms:develop Feb 20, 2015
@mkoistinen mkoistinen deleted the mkoistinen-feature/render_model_add_block branch August 12, 2015 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants