Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added screenshots to site-wide content tutorial #4801

Merged
merged 6 commits into from Dec 3, 2015

Conversation

darioalbanesi
Copy link

screenshots for side wide content

full_screen

@mkoistinen mkoistinen changed the title added screenshots to side wide conent tutorial added screenshots to site-wide content tutorial Dec 3, 2015
@mkoistinen
Copy link
Contributor

Nice additions, can you fix this:

sphinx.errors.SphinxWarning: /home/travis/build/divio/django-cms/docs/user/tutorial/30-structure-\
content-modes.rst:47: WARNING: image file not readable: user/tutorial/images/structure-button.png

@evildmp
Copy link
Contributor

evildmp commented Dec 3, 2015

@mkoistinen don't worry I will catch all errors before merging into develop.

@evildmp
Copy link
Contributor

evildmp commented Dec 3, 2015

@darioalbanesi thanks, looks like just what we need.

One question: how easy is it to add a nice big title text to the header, that is superimposed on the image? It could be added in the next section (advanced styling).

@evildmp
Copy link
Contributor

evildmp commented Dec 3, 2015

Will merge this in the meantime.

evildmp added a commit that referenced this pull request Dec 3, 2015
added screenshots to site-wide content tutorial
@evildmp evildmp merged commit 5b8ead2 into user-tutorial Dec 3, 2015
@darioalbanesi
Copy link
Author

@evildmp something like this?
title_header

@evildmp
Copy link
Contributor

evildmp commented Dec 3, 2015

@darioalbanesi yes, but is that text in the image - or superimposed via the CMS (the latter is what I suggest)

@darioalbanesi
Copy link
Author

@evildmp cms of course ;) I added a style-plugin for the feature-visual and used an extra class to align the text to the center. Used H1 and a custom text-color (which is the brand-primary color)

@FinalAngel FinalAngel deleted the tutorial/side_wide_content branch December 7, 2015 07:33
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8c5117c on tutorial/side_wide_content into ** on user-tutorial**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants