Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #5140 #5142

Merged
merged 6 commits into from
Apr 8, 2016
Merged

fixes #5140 #5142

merged 6 commits into from
Apr 8, 2016

Conversation

czpython
Copy link
Contributor

@czpython czpython commented Apr 6, 2016

  • Fixed Page marked as "pending" on move even if unpublished #5140
  • Fixed bug where an unpublished child page would be set to pending if it's parent was unpublished.
  • Refactored move_page to no longer publish pages.
    instead it now calls mark_as_published and mark_descendants_as_published.
    This is to avoid executing the whole publication logic on page move which can result in many
    inconsistencies.
  • Refactored the logic from publish() that updates the state of descendant pages
    into a new method called mark_descendants_as_published.
    This is to allow other actions like moving a page to benefit from this operation without
    calling publish(). The refactor removed a lot of dead code.

@czpython czpython self-assigned this Apr 6, 2016
@czpython czpython added this to the 3.2.x milestone Apr 6, 2016
@coveralls
Copy link

coveralls commented Apr 7, 2016

Coverage Status

Coverage increased (+0.002%) to 88.485% when pulling fe1db22 on czpython:fixes-3.3/5140 into 582b1af on divio:develop.

@czpython czpython modified the milestones: 3.3, 3.2.x Apr 8, 2016
@czpython
Copy link
Contributor Author

czpython commented Apr 8, 2016

@yakky @mkoistinen please review.
I will backport this into 3.2.x once merged.
This fixes a few critical issues on 3.2.x and thus a new release there should be planned.

@mkoistinen
Copy link
Contributor

This looks really good, @czpython. Also, thanks for both retaining existing and writing new comments. Very clear code, easy to follow and thorough. 👍

@czpython czpython merged commit afe9061 into django-cms:develop Apr 8, 2016
@czpython czpython deleted the fixes-3.3/5140 branch April 8, 2016 12:05
This was referenced Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants