Fixed an issue when link plugin couldn't be edited #5485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@vxsx Is there a test for this? |
|
@czpython nope |
vxsx
force-pushed
the
bugfix/link-plugins-not-editable
branch
from
9c9f609
to
582b78a
Compare
|
@czpython now there is :) |
Since django-cms#5429 the plugin markup has `cms-plugin` class, which means that link plugins markup would look like `<a class="cms-plugin" ...>` which wasn't handled by that doubleclick handler that previously allowed editing of plugins that contain links.
vxsx
force-pushed
the
bugfix/link-plugins-not-editable
branch
from
582b78a
to
85aaa47
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #5429 the plugin markup has
cms-pluginclass, which meansthat link plugins markup would look like
<a class="cms-plugin" ...>which wasn't handled by that doubleclick handler that previously
allowed editing of plugins that contain links.
does not require backporting