Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed delete button #5944

Closed
wants to merge 3 commits into from
Closed

Fixed delete button #5944

wants to merge 3 commits into from

Conversation

Croden
Copy link
Contributor

@Croden Croden commented Apr 21, 2017

Hardcoded "delete/" link leads to 404 - changed this to be same as "submit_line" from django itself.

Hardcoded "delete/" link leads to #404 - changed this to be same as "submit_line" from django itself.
@czpython czpython self-assigned this Apr 21, 2017
@czpython czpython added this to the 3.4.x milestone Apr 21, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.688% when pulling 860ea24 on Croden:patch-1 into e181a1b on divio:release/3.4.x.

@czpython
Copy link
Contributor

Hello @Croden,
Thank you very much for this contribution.
I've been quite busy this week, but will definitely review your pr no later than the weekend.

@czpython
Copy link
Contributor

Hello @Croden,
Which django version are you using?

@haricot
Copy link
Contributor

haricot commented May 2, 2017

It works with django 1.8 and django-cms 3.4 but not with django 1.9 and 1.10

@haricot
Copy link
Contributor

haricot commented May 3, 2017

Just an example to quickly show what happens on this issue when we try to delete an extension object:

Page not found (404)
Request Method: GET
The current URL, /fr/admin/project/iconextension/15/change/delete/, didn't match any of these.

This URL should be :

/fr/admin/project/iconextension/iconextension/15/delete/

@czpython
Copy link
Contributor

czpython commented May 3, 2017

Thanks for the clarification @haricot.
And thanks to @Croden for the patch :)

@coveralls
Copy link

coveralls commented May 3, 2017

Coverage Status

Coverage remained the same at 82.688% when pulling 860ea24 on Croden:patch-1 into e181a1b on divio:release/3.4.x.

@czpython
Copy link
Contributor

czpython commented May 3, 2017

Merged in d90102f

@czpython czpython closed this May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants