New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bugfixes for 3.5 #6177
Merged
Merged
Minor bugfixes for 3.5 #6177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vxsx
commented
Dec 11, 2017
- made "view on site" links close the sideframe (and removed bunch on unused code)
- fixed a bug where welcome page (and wizard) wouldn't respect toolbar language but instead would use the page language
vxsx
force-pushed
the
bugfix/3.5.x/minor-bugfixes
branch
from
December 11, 2017 16:15
c2a6438
to
c67b7fe
Compare
czpython
reviewed
Dec 11, 2017
cms/templates/cms/welcome.html
Outdated
@@ -1,4 +1,4 @@ | |||
<!doctype html>{% load i18n staticfiles cms_tags cms_static sekizai_tags %} | |||
<!doctype html>{% load i18n l10n staticfiles cms_tags cms_static sekizai_tags %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need the l10n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, fixed
vxsx
force-pushed
the
bugfix/3.5.x/minor-bugfixes
branch
from
December 11, 2017 16:56
c67b7fe
to
c184738
Compare
czpython
approved these changes
Dec 11, 2017
FinalAngel
approved these changes
Dec 12, 2017
vxsx
force-pushed
the
bugfix/3.5.x/minor-bugfixes
branch
from
December 12, 2017 08:30
c184738
to
1ce9c4b
Compare
vxsx
force-pushed
the
bugfix/3.5.x/minor-bugfixes
branch
from
December 12, 2017 13:32
1ce9c4b
to
59ac648
Compare
vxsx
force-pushed
the
bugfix/3.5.x/minor-bugfixes
branch
from
December 13, 2017 11:19
f62da5f
to
1daf082
Compare
vxsx
force-pushed
the
bugfix/3.5.x/minor-bugfixes
branch
from
December 13, 2017 17:49
cb8fd3c
to
6edd618
Compare
vxsx
force-pushed
the
bugfix/3.5.x/minor-bugfixes
branch
from
December 13, 2017 20:16
6edd618
to
4aaaf51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.