set white-space of first column in jstree to normal #6770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrief
changed the title
…first-column-wrap-white-space # Conflicts: # CHANGELOG.rst # cms/static/cms/css/3.7.2/cms.pagetree.css
…first-column-wrap-white-space # Conflicts: # CHANGELOG.rst # cms/static/cms/css/3.7.2/cms.pagetree.css
…om:jrief/django-cms into fixes/jstree-first-column-wrap-white-space # Conflicts: # CHANGELOG.rst
|
Rebased for version 3.7.2 and a friendly reminder that some CMS installations really use up to 255 characters for the page title. |
…om:jrief/django-cms into fixes/jstree-first-column-wrap-white-space # Conflicts: # CHANGELOG.rst
…om:jrief/django-cms into fixes/jstree-first-column-wrap-white-space
yakky
approved these changes
May 24, 2020
|
@jrief could you rebase this against develop? It will be cherrypicked to 3.7.x branch for release. As I'd really like this to be in 3.7.3 which is due soon BTW: This has been needed for a long time! 🎉 |
3 tasks
|
@jrief 🎉 thanks |
|
@FinalAngel should we close this, right? you will port this to 3.7 directly from develop |
|
I would keep both PRs separate. Reason is that the css file is compiled and minified, and hence merging presumably impossible. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the length of a page title is too long, it pushes the JS-Tree out of the visible window, creating a horizontal scroll bar at the bottom:
To prevent horizontal scrolling, we can use the proper
white-space: normalproperty, so that this text gets wrapped:Checklist
develop