Form styles #339
Merged
Form styles #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vxsx
commented
May 18, 2016
vxsx
commented
- Fixes broken styles on forms in IE
- Fixes broken sortedm2m related-widget
- Fixes broken sortedm2m checkboxes in IE
- Removes djangocms-admin-frontend.css
wasn't used and caused document.write on every request in sideframe
fixes incorrect sizing in forms in IE, fixes sortedm2m, fixes checkbox positioning
| @@ -792,6 +811,10 @@ form select[multiple] { | |||
| width: calc(100% - 91px) !important; | |||
| margin-right: 10px; | |||
| } | |||
| select + .related-widget-wrapper-link, | |||
| .related-widget-wrapper-link + .related-widget-wrapper-link { | |||
There was a problem hiding this comment.
as I understand we do not have influence on html, because such selector are too heave and looks weird a bit
There was a problem hiding this comment.
we do not, exactly.
but it's a very valid adjacent selector :)
|
overall LGTM |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.