fix field clashes with 'file' in Django 1.9 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set cmsplugin_ptr and remove related_name to avoid field name clashes with any other plugin that has a field called "file". see django-cms/django-cms#5030
| @@ -23,6 +23,13 @@ def hyphenate(t): | |||
| @python_2_unicode_compatible | |||
| class AbstractText(CMSPlugin): | |||
| """Abstract Text Plugin Class""" | |||
|
|
|||
| # Set cmsplugin_ptr and remove related_name to avoid field name clashes | |||
| # with any other plugin that has a field called "file". | |||
There was a problem hiding this comment.
a field called "abstracttext"?
There was a problem hiding this comment.
no, a field called whatever the lowercase name of the concrete subclass is called. In this case text.
There was a problem hiding this comment.
and even if it were abstracttext... still a field name you might want to use ;-)
|
👍 |
stefanfoulis
added a commit
that referenced
this pull request
Feb 26, 2016
fix field clashes with 'file' in Django 1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set cmsplugin_ptr and remove related_name to avoid field name clashes
with any other plugin that has a field called "file".
see django-cms/django-cms#5030