Include flake8 config for convenience #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, GitSavvy uses pycodestyle but it is easy to include appropriate settings for flake8 and will make contributors happy.
stoivo
approved these changes
Dec 11, 2018
asfaltboy
reviewed
Dec 12, 2018
| max-line-length = 120 | ||
| ignore = | ||
| E401, | ||
| D, |
There was a problem hiding this comment.
I'm not familiar with D violations, could you please point me to the reference (if this is not a typo that is)?
There was a problem hiding this comment.
'D' are all docstring violations. flake8 is a combination mostly of pyflakes, pycodestyle and pydocstyle.
'D' expects docstrings for modules, classes, and all public methods and functions. And they must have a specific style. One short sentence, followed by a empty line etc. It's basically noise.
There was a problem hiding this comment.
Cool, good to know, thanks for the response @kaste 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, GitSavvy uses pycodestyle but it is easy to include
appropriate settings for flake8 and will make contributors happy.