Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include flake8 config for convenience #1063

Merged
merged 1 commit into from
Dec 11, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,19 @@
count = False
ignore = E401, W503, W504
max-line-length = 120
exclude =
tests/mockito,
tests/parameterized/,
.svn,CVS,.bzr,.hg,.git

[flake8]
max-line-length = 120
ignore =
E401,
D,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with D violations, could you please point me to the reference (if this is not a typo that is)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'D' are all docstring violations. flake8 is a combination mostly of pyflakes, pycodestyle and pydocstyle.

'D' expects docstrings for modules, classes, and all public methods and functions. And they must have a specific style. One short sentence, followed by a empty line etc. It's basically noise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, good to know, thanks for the response @kaste 👍

W503,
W504
exclude =
tests/mockito,
tests/parameterized/,
.svn,CVS,.bzr,.hg,.git