Diffstat #672
Merged
Diffstat #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 good job. |
|
Actually, I would also like to see a similar summary when typing a commit message #488. |
randy3k
reviewed
Jun 16, 2017
|
|
||
| Set to `false` if don't want to show this when view a commit. | ||
| */ | ||
| "show_diffstat": true, |
There was a problem hiding this comment.
May be more clear to separate the settings for show_commit.py and show_commit_info.py?
I suggest using show_diff_stat_in_show_commit_view for show_commit.py and show_diff_stat_in_commit_info or somethings along this line.
There was a problem hiding this comment.
I think we can keep it all in one setting since if you are interested in diffstat somewhere you would probably like so see it elsewhere.
Maybe we can have one setting for all views and one setting to display it in commit view
There was a problem hiding this comment.
Fair enough. #488 is a separated issue.
randy3k
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing #671
