Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative commit view #488

Closed
yetithefoot opened this issue Aug 4, 2016 · 10 comments · Fixed by #701
Closed

More informative commit view #488

yetithefoot opened this issue Aug 4, 2016 · 10 comments · Fixed by #701

Comments

@yetithefoot
Copy link
Contributor

When im writing commit message I prefer to see changes that will be commited and branch info.

Now it looks like:
screenshot 2016-08-04 17 51 19

But view like this looks more informative:
screenshot 2016-08-04 17 51 28

Suggest extend commit view with extra information

@yetithefoot yetithefoot changed the title Add changes to be commited to commit view More informative commit view Aug 4, 2016
@divmain
Copy link
Collaborator

divmain commented Aug 4, 2016

Would this option suffice?

@aziz
Copy link
Contributor

aziz commented Aug 4, 2016

I think full diff is too much I also like to see a summary of things that are being commited.

@yetithefoot
Copy link
Contributor Author

yetithefoot commented Aug 4, 2016

@divmain Not really. As @aziz mentionned, its too much.
Probably smth like this would cover most of possible scenarios:

{
    "show_commit_diff": "full", // full changes
    "show_commit_diff": "filenames", // only filenames
    "show_commit_diff": "none" // nothing
}

In my cases filenames is enough.

@divmain
Copy link
Collaborator

divmain commented Aug 10, 2016

In #492, @tomngo asked for previous commit messages, since commit messages will often be similar. Let's come up with all the possible bits of information we might want in the commit view, and then expose a config option to allow people to set this up granularly.

One way would be to just accept a raw git command. You could pretty simply craft one to show previous commit subjects, or show a full diff, or show filenames that have changed. We could also accept an array of these, for people that want lots of info and don't want to choose between them.

However, this would be more heavy-handed, and exposing more constrained but popular choices as boolean options might be better.

Thoughts?

@tomngo
Copy link

tomngo commented Aug 10, 2016

Thanks! For convenience, I'd prefer the more constrained but popular choices. If there were a way to enhance by adding raw git commands to user preferences, I'd likely use that.

@rchl
Copy link

rchl commented Sep 19, 2016

I'd really like this improvement. One thing that wasn't mentioned is showing the branch we are on. I'd like that too.

@rchl
Copy link

rchl commented Sep 19, 2016

Ability to select previous commit messages would also sort-of solve #503.

@asfaltboy
Copy link
Member

@tomngo could you elaborate on what you mean by "'enhancing by adding raw git commands" ?

Today, you could either enhance specific GitSavvy commands with custom arguments globally, or define a custom command to do your specialized work.

Please let us know if this is satisfactory, and whether there's anything else you're looking for.

@tomngo
Copy link

tomngo commented Oct 29, 2016

@asfaltboy : My comment was a response to @divmain 's question on the same day (Aug 10). I think your "define a custom command" response already satisfies the need. Thanks!

@yetithefoot
Copy link
Contributor Author

yetithefoot commented Jul 18, 2017

Thanx. stat is exactly what was needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants