Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Redesign checkout functionality of Branch dashboard #714

Merged
merged 5 commits into from
Aug 19, 2017

Conversation

randy3k
Copy link
Collaborator

@randy3k randy3k commented Jul 20, 2017

This PR depends on #713 It is merged

  • The checkout new branch and checkout remote branch functions are combined.

  • The cursor is set a the newly checkout branch.

close #371 close #608

screen shot 2017-08-18 at 1 35 02 pm


The maintainers of this repo require that all pull request submitters agree and adhere to the following:

  • I have read and agree to the contribution guidelines.
    (required)
  • All related documentation has been updated to reflect the changes made. (required)
  • My commit messages are cleaned up and ready to merge. (required)

The maintainers of this repository require you to select the semantic version type that
the changes in this pull request represent. Please select one of the following:

  • major
  • minor
  • patch
  • documentation only

@maintainerd
Copy link

maintainerd bot commented Jul 20, 2017

maintainerd logging is enabled for this repository.

All actions related to rules and their enforcement will be logged here as a permanent record.


Click to view log...

  • 2017-07-20T06:21:12.151Z:d0112c3: The pull request was created
  • 2017-07-20T06:21:22.613Z:d0112c3: @randy3k checked I have read and agree to the [contribution guidelines](https://github.com/divmain/GitSavvy/blob/master/CONTRIBUTING.md)..
  • 2017-07-20T06:21:23.548Z:d0112c3: @randy3k checked All related documentation has been updated to reflect the changes made. _(required)_.
  • 2017-07-20T06:21:24.354Z:d0112c3: @randy3k checked My commit messages are cleaned up and ready to merge. _(required)_.
  • 2017-07-20T06:21:27.682Z:d0112c3: @randy3k selected patch as the semantic version.
  • 2017-07-20T06:21:32.887Z:d0112c3: @randy3k deselected patch as the semantic version.
  • 2017-07-20T06:21:35.607Z:d0112c3: @randy3k selected patch as the semantic version.
  • 2017-07-27T01:53:15.767Z:21032ac: @randy3k unchecked My commit messages are cleaned up and ready to merge. _(required)_.
  • 2017-07-27T03:41:39.574Z:84f65f4: @randy3k checked My commit messages are cleaned up and ready to merge. _(required)_.
  • 2017-08-19T22:40:40.160Z:e752947: @stoivo selected minor as the semantic version.
  • 2017-08-19T22:40:41.293Z:e752947: @stoivo deselected patch as the semantic version.
  • 2017-08-19T22:40:44.274Z:e752947: @stoivo selected patch as the semantic version.
  • 2017-08-19T22:40:44.592Z:e752947: @stoivo deselected minor as the semantic version.
  • 2017-08-19T22:54:48.497Z:2d79acc: @stoivo selected minor as the semantic version.
  • 2017-08-19T22:54:49.473Z:2d79acc: @stoivo deselected patch as the semantic version.

@randy3k randy3k force-pushed the randy3k/checkout branch 6 times, most recently from 9d86491 to 21032ac Compare July 25, 2017 15:30
@randy3k randy3k added the next label Jul 27, 2017
@randy3k randy3k force-pushed the randy3k/checkout branch 4 times, most recently from 5de6410 to 21e2cd7 Compare August 3, 2017 02:36
@randy3k randy3k changed the base branch from develope to master August 3, 2017 02:38
@randy3k randy3k force-pushed the randy3k/checkout branch 4 times, most recently from e255d69 to 90cc333 Compare August 18, 2017 16:59
@randy3k randy3k changed the title Redesign checkout functionality of Branch dashboard Enhancement: Redesign checkout functionality of Branch dashboard Aug 18, 2017
Copy link
Member

@stoivo stoivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes looks good, I added a commit to fix if the cursor was after the selected branch.

As @divmain wrote in #371 (comment) we should make a dump in the releases here. I think that if we make it a minor and add a release note it would be good enough?
No need to make it major

@randy3k
Copy link
Collaborator Author

randy3k commented Aug 19, 2017

I agree. The change is not entirely breaking the old functionality.

@stoivo
Copy link
Member

stoivo commented Aug 19, 2017

Does it work just to change the checkboxes now?
Should I add the release notes?

@randy3k
Copy link
Collaborator Author

randy3k commented Aug 19, 2017

Changing the check box should work. It will be great if you can prepare the release note.

@randy3k
Copy link
Collaborator Author

randy3k commented Aug 19, 2017

Btw, should the next release also include #728 and #739?

@stoivo
Copy link
Member

stoivo commented Aug 19, 2017

Yes, I will go through them now.

@stoivo stoivo merged commit 7d16c8d into master Aug 19, 2017
@stoivo stoivo deleted the randy3k/checkout branch August 19, 2017 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants