Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: offer push to remote rather than configuring remote #739

Merged
merged 3 commits into from
Aug 19, 2017
Merged

Enhancement: offer push to remote rather than configuring remote #739

merged 3 commits into from
Aug 19, 2017

Conversation

randy3k
Copy link
Collaborator

@randy3k randy3k commented Aug 15, 2017

Close #738
when creating PR without tracking remote, prompt to push to remote instead of asking to configure remote tracking branch.

PS: this PR is created by this feature.


The maintainers of this repo require that all pull request submitters agree and adhere to the following:

  • I have read and agree to the contribution guidelines.
    (required)
  • All related documentation has been updated to reflect the changes made. (required)
  • My commit messages are cleaned up and ready to merge. (required)

The maintainers of this repository require you to select the semantic version type that
the changes in this pull request represent. Please select one of the following:

  • major
  • minor
  • patch
  • documentation only

@maintainerd
Copy link

maintainerd bot commented Aug 15, 2017

maintainerd logging is enabled for this repository.

All actions related to rules and their enforcement will be logged here as a permanent record.


Click to view log...

  • 2017-08-15T19:57:27.781Z:05000fc: The pull request was created
  • 2017-08-15T20:03:25.329Z:d12ee8e: @randy3k checked All related documentation has been updated to reflect the changes made. _(required)_.
  • 2017-08-15T20:03:26.866Z:d12ee8e: @randy3k selected minor as the semantic version.
  • 2017-08-15T20:03:27.423Z:d12ee8e: @randy3k deselected minor as the semantic version.
  • 2017-08-15T20:03:27.843Z:d12ee8e: @randy3k selected patch as the semantic version.
  • 2017-08-15T20:04:10.451Z:d12ee8e: @randy3k checked I have read and agree to the [contribution guidelines](https://github.com/divmain/GitSavvy/blob/master/CONTRIBUTING.md)..
  • 2017-08-15T20:04:11.885Z:d12ee8e: @randy3k checked My commit messages are cleaned up and ready to merge. _(required)_.
  • 2017-08-15T20:18:55.077Z:d12ee8e: @randy3k selected patch as the semantic version.
  • 2017-08-15T20:18:58.116Z:d12ee8e: @randy3k selected minor as the semantic version.
  • 2017-08-15T20:18:58.485Z:d12ee8e: @randy3k deselected minor as the semantic version.
  • 2017-08-15T20:18:59.159Z:d12ee8e: @randy3k deselected patch as the semantic version.
  • 2017-08-15T20:19:03.736Z:d12ee8e: @randy3k deselected patch as the semantic version.
  • 2017-08-15T20:20:06.188Z:d12ee8e: @randy3k deselected patch as the semantic version.
  • 2017-08-15T20:20:12.531Z:d12ee8e: @randy3k selected patch as the semantic version.
  • 2017-08-15T20:20:18.927Z:d12ee8e: @randy3k selected patch as the semantic version.
  • 2017-08-15T20:24:00.955Z:d12ee8e: @randy3k selected patch as the semantic version.
  • 2017-08-15T20:25:21.238Z:d12ee8e: @randy3k deselected patch as the semantic version.
  • 2017-08-15T20:26:50.825Z:d12ee8e: @randy3k selected patch as the semantic version.
  • 2017-08-15T20:31:15.263Z:d12ee8e: @randy3k deselected patch as the semantic version.
  • 2017-08-15T20:31:28.880Z:d12ee8e: @randy3k selected patch as the semantic version.

@stoivo
Copy link
Member

stoivo commented Aug 19, 2017

What is the benefit of using WindowCommand instead of TextCommand, performance?

@stoivo stoivo merged commit 7632549 into timbrel:master Aug 19, 2017
@randy3k randy3k deleted the pull_request branch August 19, 2017 23:09
@randy3k
Copy link
Collaborator Author

randy3k commented Aug 19, 2017

We don't need any view to invoke these commands.

@randy3k
Copy link
Collaborator Author

randy3k commented Aug 20, 2017

Thanks @stoivo

@sheldon
Copy link

sheldon commented Aug 21, 2017

Thanks for the really quick implementation, this does exactly what I had in mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants