iso: copy input closourse into iso to avoide re-download

[blaggacao]

closes #190

Tested on my setup, considerably cuts times and only leaves one (noticable) download.

[blaggacao]

bors try

[Pacman99]

ohh wait I actually haven't tested that code locally, I just wrote the code out. But it should be simple enough to build the isoConfig and inspect the result.

[blaggacao]

ohh wait I actually haven't tested that code locally, I just wrote the code out. But it should be simple enough to build the isoConfig and inspect the result.

I fully tried end to end and it works.

nix registry list shows all those local store paths.

Maybe we need to filter out the ones that are flake = false, though? or handle them differently? What do you think?

[Pacman99]

Yeah you could, but it really wouldn't make much of a difference. Worst case theres just one unnecessary folder in the nix store.

[blaggacao]

Yeah you could, but it really wouldn't make much of a difference. Worst case theres just one unnecessary folder in the nix store.

Ok, let's don't bother then. That path might even be useful on the iso under some odd circumstances.

[Pacman99]

So I'm not sure about this. But perhaps we could not import all modules of the system and just selectively pass along parts of the configuration. This would prevent starting up unnecessary system services while still adding necessary dependencies.

I think this would involve evaluating the modules in a seperate nixosSystem call. And just passing along some things.

for example:

environment = { inherit (system.config.environment) systemPackages; };

[blaggacao]

So I'm not sure about this. But perhaps we could not import all modules of the system and just selectively pass along parts of the configuration. This would prevent starting up unnecessary system services while still adding necessary dependencies.

Do you refer to your previous suggestion to not enable all modules?

This PR is meant (and restrained to) specifically to target #190. I'll open an issue for that.

[Pacman99]

Yeah its just another idea. Doesn't have to be a part of this PR.

[blaggacao]

x-ref: #194

[bors]

try

Build succeeded:

• ci/hercules/evaluation
• ci/hercules/derivations

[nrdxp]

if it's ready, go ahead and merge
bors delegate+

[bors]

✌️ blaggacao can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

[nrdxp]

LGTM

[blaggacao]

I suspect that it actually does not cache evaluations, since the commands still take some time in silence, that is no command output (which I only can explain with evaluation)?

Can those evaluations, like this, for example, also be copied into the store?

Let's make this a separate issue, for now, on slow machines it still amounts to some 60 seconds or so.

[blaggacao]

bors r+

[bors]

Build succeeded:

• ci/hercules/derivations
• ci/hercules/evaluation