Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core #301

Merged
merged 18 commits into from
Jun 9, 2021
Merged

Update core #301

merged 18 commits into from
Jun 9, 2021

Conversation

Pacman99
Copy link
Member

@Pacman99 Pacman99 commented Jun 1, 2021

Most of the changes were in digga

Pacman99 and others added 8 commits May 14, 2021 18:36
Co-authored-by: David Arnold <dar@xoe.solutions>
279: Agenix integration r=blaggacao a=Pacman99

AFAICT This is mostly a documentation thing. But with divnix/digga-old#2 we can now add agenix to the devshell.

Co-authored-by: Pacman99 <pachum99@gmail.com>
flake: update to new digga api
@blaggacao
Copy link
Contributor

Should we wait for @gytis-ivaskevicius to cut a release for fup?

jwygoda and others added 2 commits June 3, 2021 08:48
302: customBuilds: add digitalOcean r=Pacman99 a=jwygoda

#42

Co-authored-by: Jarosław Wygoda <jaroslaw@wygoda.me>
@Pacman99
Copy link
Member Author

Pacman99 commented Jun 3, 2021

Should we wait for @gytis-ivaskevicius to cut a release for fup?

Since fup input is locked in digga, I personally don't think thats a blocker. If we extensively test digga with a certain fup version then it doesn't really matter if we're using staging or master

almostnobody and others added 2 commits June 8, 2021 22:10
Co-authored-by: Pacman99 <pachum99@myrdd.info>
@blaggacao
Copy link
Contributor

digga 0.2.0 is under way. Should we timely move forward with this, too, and then continue to polish from a fresh master / core?

@Pacman99
Copy link
Member Author

Pacman99 commented Jun 9, 2021

Should we timely move forward with this, too, and then continue to polish from a fresh master / core?

Yes lets do that


They are defined with the `suites` argument in either `home` or `nixos` namespace.
They are defined with the `suites` argument in either the `home` or `nixos` namespace.
Suites should be passed as a function that take profiles as an argument.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a left over.

Copy link
Contributor

@blaggacao blaggacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

digga:develop -> digga:master !?

flake.nix Outdated Show resolved Hide resolved
@blaggacao
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 9, 2021

Build succeeded:

@bors bors bot merged commit b3118a6 into core Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants