Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated option name #385

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Fix outdated option name #385

merged 1 commit into from
Jan 11, 2022

Conversation

blm768
Copy link
Contributor

@blm768 blm768 commented Oct 4, 2021

While muddling through #381, I realized the docs had a reference to an option that had been renamed.

I'm not sure yet whether any changes should be made to the example in the previous section, as the default seems to be to pull stuff in from hmUsers rather than directly specifying options like the example does, but I'm not sure what we'd consider best practice there.

@Pacman99
Copy link
Member

Pacman99 commented Oct 4, 2021

Ohh I see I think we need be more clear as to what we're referring to, but the option is actually home-manager. That code is using the home-manager nixos module, not the digga api.

@blm768
Copy link
Contributor Author

blm768 commented Oct 5, 2021

That code is using the home-manager nixos module, not the digga api.

Right. I think the example should work as given, but it doesn't match the current state of the template, which presumably expects the profiles to be configured in flake.nix:

{
  home-manager.users = { inherit (hmUsers) nixos; };
}

@blm768
Copy link
Contributor Author

blm768 commented Jan 9, 2022

Ohh I see I think we need be more clear as to what we're referring to, but the option is actually home-manager. That code is using the home-manager nixos module, not the digga api.

Were you referring to the option I changed or the option in the example above it? It's been a while now, but I think I remember that the one I changed was using digga's API.

@Pacman99
Copy link
Member

Pacman99 commented Jan 9, 2022

Right yeah you were correct originally, I'm sorry about my confusion.
I just added a comment with a slight change to specify what file the docs are talking about. With that, I'm happy to merge this.

@Pacman99 Pacman99 merged commit 283f6b2 into divnix:main Jan 11, 2022
@blm768 blm768 deleted the update-docs branch January 12, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants