This repository has been archived by the owner on Apr 22, 2022. It is now read-only.
Support mapping native Avro timestamps. #245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include: - The timestamp() and clientTimestamp() providers now produce native timestamps. - Updating some of the test scaffolding so that we can test the decoded Avro record, not the mapped one. The mapped one is prior to 'conversions' that we want to check for. Backwards compatibility for mappings is impacted by this change: the timestamp providers can no longer map onto long fields unless they have the correct logical type. Fixing this is hard: Avro only lets us set the logical type, not the raw type, and providers don't know the target type so we can't adjust their behaviour depending on the target.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
timestamp()andclientTimestamp()providers to produce native timestamps that can be mapped to Avro fields with the timestamp logical types.Such records are compatible with downstream consumers, but on the Divolte side schemas will need to be updated so that the timestamp fields have the correct logical types.
Documentation updates are also required.