This repository has been archived by the owner on Apr 22, 2022. It is now read-only.
Upgrade divolte and add default hdfs sink configuration.Fixes #4 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Aug 16, 2018
start.sh
Outdated
| if [ -z "$DIVOLTE_HDFS_SINK_WORKING_DIR" ]; then | ||
| # No specific dir set use default and create it if not exists | ||
| if [ ! -d /tmp/working ]; then | ||
| mkdir -p /tmp/working |
There was a problem hiding this comment.
mkdir -p does not really care if the directory already exists:
MacBook-Pro-van-Fokko:~ fokkodriesprong$ mkdir -p /tmp/
MacBook-Pro-van-Fokko:~ fokkodriesprong$ mkdir -p /tmp/
MacBook-Pro-van-Fokko:~ fokkodriesprong$ echo $?
0
There was a problem hiding this comment.
Thx. Done like suggested
start.sh
Outdated
| else | ||
| #make sure dir exists | ||
| if [ ! -d "$DIVOLTE_HDFS_SINK_WORKING_DIR" ]; then | ||
| mkdir -p "$DIVOLTE_HDFS_SINK_WORKING_DIR" |
There was a problem hiding this comment.
The mkdir -p "$DIVOLTE_HDFS_SINK_WORKING_DIR" might be nicer than the mkdir -p /tmp/working above.
I would change it to:
DIVOLTE_HDFS_SINK_WORKING_DIR=${DIVOLTE_HDFS_SINK_WORKING_DIR:/tmp/working}
mkdir -p "$DIVOLTE_HDFS_SINK_WORKING_DIR"
But this is a matter of taste I'd say.
There was a problem hiding this comment.
I like your taste. Done like this....
Fokko
approved these changes
Aug 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.