Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite demo script #1123

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Rewrite demo script #1123

merged 2 commits into from
Jun 17, 2024

Conversation

tgeoghegan
Copy link
Contributor

  • Autopair the second aggregator in compose.yaml
  • Rewrite demo script to guide users through brining up docker compose environment and then doing aggregations against it

Part of #1096

@tgeoghegan
Rewrite demo script
17e981a 
- Autopair the second aggregator in `compose.yaml`
- Rewrite demo script to guide users through brining up `docker compose`
  environment and then doing aggregations against it

Part of #1096
@tgeoghegan tgeoghegan requested a review from a team as a code owner June 17, 2024 17:20
@tgeoghegan
Copy link
Contributor Author

I think the handling of collector credential is still kinda clumsy. It feels silly to have to wrangle both a credential UUID and a collector credential file. We may improve this in #1033 and #1073 which would require further demo script updates.

@tgeoghegan tgeoghegan mentioned this pull request Jun 17, 2024
Open
9 tasks
@tgeoghegan tgeoghegan merged commit 6aeb765 into main Jun 17, 2024
8 checks passed
@tgeoghegan tgeoghegan deleted the timg/demo-script branch June 17, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divergentdave divergentdave divergentdave approved these changes

@branlwyd branlwyd branlwyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgeoghegan @divergentdave @branlwyd