Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GET /tasks/:task_id #383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add GET /tasks/:task_id #383

wants to merge 1 commit into from

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Aug 7, 2023 •
edited
Loading

@jbr jbr requested a review from a team as a code owner August 7, 2023 20:54
@jbr jbr changed the title add /tasks/:task_id add GET /tasks/:task_id Aug 7, 2023
jbr
jbr commented Aug 7, 2023
View reviewed changes
documentation/public-task-api.md
@@ -33,15 +33,14 @@ We add an infinitely cacheable (`Cache-Control: public, max-age=604800`) endpoin
"leader": "https://dap.xxqbi.example/",
"helper": "https://dap.xxqbi.example/",
"time_precision_seconds": 1080,
"protocol": "DAP-04"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed because we have no way of determining per-task protocol currently. We will likely want to add that eventually

@jbr jbr mentioned this pull request Aug 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divergentdave divergentdave divergentdave approved these changes

@branlwyd branlwyd branlwyd approved these changes

@tgeoghegan tgeoghegan tgeoghegan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbr @divergentdave @branlwyd @tgeoghegan