DAP-09 support #880
Merged
DAP-09 support #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, nevermind, I just noticed #874. |
|
This looks like a worthwhile incremental (if incomplete) step towards DAP-09 |
jbr
approved these changes
Mar 14, 2024
divergentdave
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Yeah, I think we should land these enum updates first, as teasing out the query type will take a sizable refactor, and this change alone can unblock other work.
It looks like we won't need a database migration, since the protocol just gets stored in a nullable string column, not a Postgres enum.
|
Sounds good! |
inahga
force-pushed
the
inahga/aggregator-api-dap
branch
from
0259822
to
040ef3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #878.
Adds support for aggregators that report themselves as DAP-09. AFAICT there are no functional changes required, just recognition.