Job driver: wait for in-flight jobs upon SIGTERM #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branlwyd
approved these changes
Jul 3, 2023
| min_job_discovery_delay, | ||
| max_job_discovery_delay, | ||
| max_concurrent_job_workers, | ||
| max_concurrent_job_workers_u32, |
There was a problem hiding this comment.
IMO, rather than storing the same value twice, do the conversion at point-of-use. It looks like the _u32 version is only used in one place, during shutdown, so this should be OK. We can keep an attempted conversion in new to validate that the given value can be represented as a u32, then unwrap when we do the conversion "for real".
divergentdave
force-pushed
the
david/job-driver-wait-in-flight
branch
from
d635490
to
ff070f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1502.