Fix bug with trailing slashes in URL #1644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1579 (comment) I identified cases where
https://example.com
would be encoded ashttps://example.com/
(notice the trailing slash). At the time I didn't think this was relevant, but it turns out to affect task ID derivation.Task ID derivation is
sha256sum(encoded_task_config)
. If we are peered with a non-janus aggregator and if we introduce trailing slashes, Janus could derive a different task ID than its peer. (This is actually somewhat unlikely since we'd derive task ID directly from the encoded bytes, but is a subtle inconsistency that could hit us later).Instead, provide
TryInto<url::Url>
to ease converting DAP Urls to a more useful type.