Replace sleep calls in tests with a direct cache refresh function
#1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inahga
commented
Jul 26, 2023
aggregator/src/cache.rs
Outdated
| @@ -125,9 +128,25 @@ impl GlobalHpkeKeypairCache { | |||
| let keypairs = self.keypairs.lock().unwrap(); | |||
| keypairs.get(id).cloned() | |||
| } | |||
|
|
|||
| #[cfg(feature = "test-util")] | |||
| pub async fn refresh(&self) -> Result<(), Error> { | |||
There was a problem hiding this comment.
I think we should extract the common body of this and the async block in new() to a new private method.
|
#1649 for renaming function. |
Make rustdoc happy Errant file change Cleanups
inahga
force-pushed
the
inahga/no-sleep-in-tests
branch
from
bafcf8c
to
de52002
Compare
inahga
commented
Jul 27, 2023
divergentdave
approved these changes
Jul 27, 2023
Co-authored-by: David Cook <dcook@divviup.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1640 (comment).