Fix flaky argument parsing test #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests for `collect` binary argument handling were occasionally
failing. In one such run ([1]), we observe that the test randomly
generated an auth token `-7ekJePnK7WXktf92bK1CQ`, which starts with `-`
and confuses `clap`, which tries to treat it as a series of flags rather
than the value to `--dap-auth-token`. We rule this out by using the
`--dap-auth-token={token}` form, as these tests already did for task IDs
and other values that can start with `-`.
[1]: https://github.com/divviup/janus/actions/runs/5733188592/job/15537476867
divergentdave
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for
collectbinary argument handling were occasionally failing. In one such run (1), we observe that the test randomly generated an auth token-7ekJePnK7WXktf92bK1CQ, which starts with-and confusesclap, which tries to treat it as a series of flags rather than the value to--dap-auth-token. We rule this out by using the--dap-auth-token={token}form, as these tests already did for task IDs and other values that can start with-.