Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace type names in impls with Self #1672

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Replace type names in impls with Self #1672

merged 1 commit into from
Aug 3, 2023

Conversation

inahga
Copy link
Contributor

@inahga inahga commented Aug 3, 2023

Fix this nit: these explicit types in impls should have been Selfs.

@inahga inahga marked this pull request as ready for review August 3, 2023 18:49
@inahga inahga requested a review from a team as a code owner August 3, 2023 18:49
@inahga inahga enabled auto-merge (squash) August 3, 2023 18:50
@inahga inahga merged commit 7daccda into main Aug 3, 2023
7 checks passed
@inahga inahga deleted the inahga/self-nit branch August 3, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branlwyd branlwyd branlwyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inahga @branlwyd