One VDAF verify key per task #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The security analysis done for DAP-04 concluded that the VDAF verify key must be agreed upon by aggregators before any reports may be aggregated and cannot later be changed. That means a DAP task can only ever have a single VDAF verify key. This commit simplifies the representation of tasks in the various in-memory structures as well as the database to reflect this. The biggest change is that we no longer have table `task_vdaf_verify_keys` and instead add a row `vdaf_verify_key` to table `tasks`. Part of #1524, #1521
tgeoghegan
added
the
allow-changed-migrations
inahga
approved these changes
Sep 20, 2023
branlwyd
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The security analysis done for DAP-04 concluded that the VDAF verify key must be agreed upon by aggregators before any reports may be aggregated and cannot later be changed. That means a DAP task can only ever have a single VDAF verify key. This commit simplifies the representation of tasks in the various in-memory structures as well as the database to reflect this. The biggest change is that we no longer have table
task_vdaf_verify_keysand instead add a rowvdaf_verify_keyto tabletasks.Part of #1524, #1521