Task rewrite: adopt AggregatorTask in taskprov
#2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inahga
reviewed
Sep 29, 2023
Comment on lines
-269
to
-271
| /// Newtype for [`task::Task`], which omits certain fields that aren't required for taskprov tasks. | ||
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| pub struct Task(pub(super) task::Task); |
tgeoghegan
force-pushed
the
timg/new-task-query-type
branch
from
3e7d66d
to
0580256
Compare
inahga
approved these changes
Sep 29, 2023
Adopts `janus_aggregator_core::task::AggregatorTask` in the `taskprov` module and code that uses it in `janus_aggregator`. Of particular interest is that we do away with `janus_aggregator_core::taskprov::Task` and instead represent taskprov tasks as a `janus_aggregator_core::task::Task` with `AggregatorTaskParameters::TaskProvHelper`. Hopefully we'll be able to further unify handling of taskprov and regular tasks in the future. Part of #1524
tgeoghegan
force-pushed
the
timg/new-task-taskprov
branch
from
7224d51
to
913bf7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #2018
Adopts
janus_aggregator_core::task::AggregatorTaskin thetaskprovmodule and code that uses it injanus_aggregator.Of particular interest is that we do away with
janus_aggregator_core::taskprov::Taskand instead represent taskprov tasks as ajanus_aggregator_core::task::TaskwithAggregatorTaskParameters::TaskProvHelper. Hopefully we'll be able to further unify handling of taskprov and regular tasks in the future.Part of #1524