Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advertise support for time bucketed fixed size #3001

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Advertise support for time bucketed fixed size #3001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e7e17d
Advertise support for time bucketed fixed size
inahga Apr 10, 2024
6426668
We have a test for this?
inahga Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions aggregator_api/src/routes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ pub(super) async fn get_config(
SupportedQueryType::TimeInterval,
SupportedQueryType::FixedSize,
],
// Unconditionally indicate to divviup-api that we support collector auth token hashes and
// upload metrics.
features: &["TokenHash", "UploadMetrics"],
features: &["TokenHash", "UploadMetrics", "TimeBucketedFixedSize"],
})
}

Expand Down
2 changes: 1 addition & 1 deletion aggregator_api/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ async fn get_config() {
r#"{"protocol":"DAP-09","dap_url":"https://dap.url/","role":"Either","vdafs":"#,
r#"["Prio3Count","Prio3Sum","Prio3Histogram","Prio3SumVec"],"#,
r#""query_types":["TimeInterval","FixedSize"],"#,
r#""features":["TokenHash","UploadMetrics"]}"#,
r#""features":["TokenHash","UploadMetrics","TimeBucketedFixedSize"]}"#,
)
);
}
Expand Down
Loading