Fix Helper aggregation-initialization report-replayed check. #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, we now check only if the corresponding row exists in the `client_reports` table, rather than ignoring that fact and looking for a corresponding `report_aggregations` row. This means we no longer respect whether the other aggregation used a different aggregation parameter, but that's fine -- Janus now supports only a single aggregation per report. This fixes a few bugs: * If the same report was repeatedly submitted in different aggregation jobs, the first instance would be aggregated; the second instance would be marked as a replay; and the third and further instances would result in an HTTP 500 error, as `check_other_report_aggregation_exists` mistakenly expected at most a single matching `report_aggregations` row to exist. * If the same report was submitted in more than one aggregation job concurrently, Janus would have aggregated both. This was a privacy bug.
|
Closes #3142. |
divergentdave
approved these changes
May 17, 2024
aggregator/src/aggregator/http_handlers/tests/aggregation_job_init.rs
Outdated
Show resolved
Hide resolved
tgeoghegan
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, we now check only if the corresponding row exists in the
client_reportstable, rather than ignoring that fact and looking for a correspondingreport_aggregationsrow. This means we no longer respect whether the other aggregation used a different aggregation parameter, but that's fine -- Janus now supports only a single aggregation per report.This fixes a few bugs:
check_other_report_aggregation_existsmistakenly expected at most a single matchingreport_aggregationsrow to exist.