Upgrade testcontainers to 0.20.0 #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divergentdave
commented
Jul 9, 2024
| @@ -687,6 +684,6 @@ pub mod test_util { | |||
| } | |||
|
|
|||
| pub fn generate_unique_name(prefix: &str) -> String { | |||
| format!("{}_{}", prefix, hex::encode(random::<[u8; 4]>())) | |||
| format!("{}-{}", prefix, hex::encode(random::<[u8; 4]>())) | |||
There was a problem hiding this comment.
FWIW, this is necessary to fix issues in the end_to_end test. I was seeing error messages in container logs saying that requests couldn't be made because hostnames were invalid. I think this happened because testcontainers now turns on the reqwest/hickory-dns feature, and Hickory is more strict about underscores not being allowed in hostnames.
inahga
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been four testcontainers releases over the past few months, and Dependabot has been failing to propose upgrades. Plus, there were a number of breaking changes to improve the API. This PR upgrades to the latest version and fixes various errors along the way.