Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public bitvector helpers #820

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Add public bitvector helpers #820

merged 3 commits into from
Nov 15, 2023

Conversation

divergentdave
Copy link
Contributor

This is stacked on #819.

This closes #643, by adding encoding and decoding methods for bitvector representations of integers. Internal uses of fill_with_bitvector_representation() and the existing encode_into_bitvector_representation() are rewritten to use the new iterator-based method.

Copy link
Collaborator

@tgeoghegan tgeoghegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but LGTM!

src/field.rs Show resolved Hide resolved
src/field.rs Outdated Show resolved Hide resolved
src/field.rs Outdated Show resolved Hide resolved
src/field.rs Outdated Show resolved Hide resolved
@divergentdave divergentdave merged commit 99ecc77 into main Nov 15, 2023
6 checks passed
@divergentdave divergentdave deleted the david/bitvector-helpers branch November 15, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field: Expose methods for converting to/from bitvector encoding
2 participants