Update XOFs to use TurboSHAKE128 #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inahga
approved these changes
Nov 28, 2023
tests/discrete_gauss.rs
Outdated
Comment on lines
46
to
49
| serde_json::from_str(include_str!(concat!( | ||
| "test_vectors/discrete_gauss_2.342.json" | ||
| ))) | ||
| .unwrap(), |
There was a problem hiding this comment.
nit: use of concat! on lines 32-49 is unnecessary
cjpatton
approved these changes
Nov 28, 2023
|
True, but since I've changed XofFixedKeyAes128 here, it's no longer compatible with VDAF-07 either. Mainly I just wanted to update all the document references in one go, since so many of them were near affected code in one way or another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements XofTurboShake128, updates XofFixedKeyAes128, updates test vectors that were only affected by XOF changes, and temporarily ignores other VDAF test vectors. Part of #839.