This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
facilitator: generate sample ingestion data #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the start of the facilitator Rust crate, which will be the executable that processes data shares, does validation and emits aggregates. This commit includes support for reading ingestion headers, signatures and data share packets in and out of the Avro format.
Starting toward sample ingestion data generation
Implements all(?) the necessary command line flags and writes an Avro ingestion header to the specified path.
sample.rs can now emit an ingestion batch header and arbitrarily many data share packets. It emits ingestion data for both the PHA and facilitator servers. I tried for a long time to get a generic interface over MemoryTransport and FileTransport working, but I can't quite get the generic put() on MemoryTransport to work because of issues with the lifetime of the boxed object. I have given up for now and just made tests use temporary dirs that get cleaned up automatically (testing was the only point of MemoryTransport to begin with).
|
I have made more progress beyond what's in this PR, including substantial refactorings of the code in here, in the timg/ingestion-validation branch. To avoid redundant reviews and rebases, I'm going to rescind this PR and work with yuriks to review a larger changeset. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Rust target for the facilitator binary that will implement the map and reduce jobs for the facilitator server. At the moment, it only implements generation of sample ingestion data from random values.