Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ExternalSort project documentation adhereing to canvas course project instructions #29

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

divy9881
Copy link
Owner

@divy9881 divy9881 commented Dec 6, 2023

No description provided.

…se project instructions

Signed-off-by: Divy Patel <divy9881@gmail.com>
Copy link
Collaborator

@sahilnaphade sahilnaphade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment inline
Also they have asked us to mention the individual contribution in the README.

README.md Outdated
# Reasons we chose to implement the specific subset of techniques
# Project's state(complete or have what kinds of bugs)
# Reasons we chose to implement the specific subset of techniques
- `Tournament-tree priority queue` was used in order to achieve `high fan-in` for merging our sorted run inputs of records
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add
"and less number of comparisons than a standard tree-of-winners" (We are using the tree of losers tournament tree)

…se project instructions

Signed-off-by: Divy Patel <divy9881@gmail.com>
…se project instructions

Signed-off-by: Divy Patel <divy9881@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants