Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add ACE Name support #210

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Re-add ACE Name support #210

merged 1 commit into from
Nov 1, 2022

Conversation

diwako
Copy link
Owner

@diwako diwako commented Oct 31, 2022

Why? I wanted to re-add it back a while ago, as it wasn't the Error: No Object culprit.

@diwako diwako added the enhancement New feature or request label Oct 31, 2022
@diwako diwako added this to the 1.10.0 milestone Oct 31, 2022
jokoho48
jokoho48 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@jokoho48 jokoho48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diwako diwako merged commit 6fc2b5e into master Nov 1, 2022
@diwako diwako deleted the add_back_ace_name_support branch November 1, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokoho48 jokoho48 jokoho48 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diwako @jokoho48