Provide support for internal CA #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork
This provides the ability to utilize the provided internal CA cert to validate a client certificate. TODO: Provide documentation on how to setup a directory of trusted root authorities.
|
HTTPS without option to use internal CA seems a bit useless - when can we expect this PR to be merged? I've tested this change and it appear to be workin as expected. |
|
This implementation does not take into account the environment variables that requests offers to override the CA cert path. I have submitted another pull request to take that into account: #160 |
|
implemented by #160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to pass in a ca_trust_path is provided but doesn't looked to be utilized.
This small update fixes that.
The python requests library has a verify parameter that can be set to True/False or be provided with a path to a certificate chain. If you pass in a ca_trust_path that will be utilized for verification.