Add a parameter to limit the number of loops to wait for winrm to reply. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If windows has a file locked or the registry is locked winrm will loop forever waiting for a reply.
This makes ansible useless when it is used with thousands of servers as once a server gets blocked it does not continue.
When instantiating
Protocol(orSessionas kwargs are passed from Session to Protocol) a new parametercommand_loopis added, being the number of loops get_command_output will do before it raises a timeout exception. By default this is 0 and it will loop forever, maintaining the existing functionality.Once winrm in get_command_output returns with 'WinRMOperationTimeoutError' seconds * command_loops, it will raise:
WinRMError('Too many loops waiting for command_done ({0})'.format(self.command_loops))